Skip to content

Add options to use playwright screenshot script for other things #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbkr merged 2 commits into from
Jul 22, 2025
Merged

Add options to use playwright screenshot script for other things #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2527e29
Add options to use playwright screenshot script for other things
dbkr Jul 18, 2025
80adec4
Probably better not to keep this given how spammy it is
dbkr Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 48 additions & 18 deletions packages/element-web-playwright-common/playwright-screenshots.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,24 @@ SCRIPT_PATH=$(readlink -f "$0")
SCRIPT_DIR=$(dirname "$SCRIPT_PATH")

IMAGE_NAME="element-web-playwright-common"
echo "Building $IMAGE_NAME image in $SCRIPT_DIR"

# Build image
PW_VERSION=$(
yarn list \
--pattern @playwright/test \
--depth=0 \
--json \
--non-interactive \
--no-progress | \
jq -r '.data.trees[].name | split("@")[2]' \
)
echo "with Playwright version $PW_VERSION"

docker build -t "$IMAGE_NAME" --build-arg "PLAYWRIGHT_VERSION=$PW_VERSION" "$SCRIPT_DIR"

build_image() {
echo "Building $IMAGE_NAME image in $SCRIPT_DIR"

# Build image
PW_VERSION=$(
yarn list \
--pattern @playwright/test \
--depth=0 \
--json \
--non-interactive \
--no-progress | \
jq -r '.data.trees[].name | split("@")[2]' \
)
echo "with Playwright version $PW_VERSION"

docker build -t "$IMAGE_NAME" --build-arg "PLAYWRIGHT_VERSION=$PW_VERSION" "$SCRIPT_DIR"
}

RUN_ARGS=(
--rm
Expand All @@ -36,6 +39,35 @@ RUN_ARGS=(
-it
)

DEFAULT_ARGS=(--grep @screenshot)

# Some arguments to customise behaviour so the same script / image can be
# re-used for other screenshot generation.
while [[ $# -gt 0 ]]; do
case "$1" in
# Mounts a separate node_modules directory from a docker volume in the container.
# Must be used if executing something that requires native node modules
# It's a volume rather than a directory because otherwise things tend to start picking up
# files from it in the native environment and break.
--with-node-modules)
RUN_ARGS+=(--mount "type=volume,src=ew-docker-node-modules,dst=/work/node_modules,volume-nocopy")
shift
;;
# Sets a different entrypoint (in which case the default arguments to the script will be ignored)
--entrypoint)
shift
RUN_ARGS+=(--entrypoint "$1")
DEFAULT_ARGS=()
shift
;;
*)
break
;;
esac
done

build_image

# Ensure we pass all symlinked node_modules to the container
pushd node_modules || exit > /dev/null
SYMLINKS=$(find . -maxdepth 2 -type l -not -path "./.bin/*")
Expand All @@ -48,6 +80,4 @@ for LINK in $SYMLINKS; do
fi
done

DEFAULT_ARGS=(--grep @screenshot)

docker run "${RUN_ARGS[@]}" "$IMAGE_NAME" "${DEFAULT_ARGS[@]}" "$@"
docker run "${RUN_ARGS[@]}" "$IMAGE_NAME" "${DEFAULT_ARGS[@]}" "$@"