Skip to content

Support for experimental MSC4286 to not render external payment details #7927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025

Conversation

hughns
Copy link
Member

@hughns hughns commented May 7, 2025

Ref: matrix-org/matrix-spec-proposals#4286

Before After
Simulator Screenshot - iPhone 16 Pro - 2025-05-26 at 17 38 09 Simulator Screenshot - iPhone 16 Pro - 2025-05-26 at 17 35 46

In the above example the formatted_body of the event looks like this:

Thanks for subscribing!<span data-msc4286-external-payment-details> You can manage your subscription and view your payment history <a href="https://account.example.com/account/plan">here</a> at any time</span>

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.56%. Comparing base (478d4f7) to head (5a769d6).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7927      +/-   ##
===========================================
+ Coverage    14.40%   15.56%   +1.16%     
===========================================
  Files         1812     1812              
  Lines       173783   173783              
  Branches     67244    67244              
===========================================
+ Hits         25028    27050    +2022     
+ Misses      148105   146083    -2022     
  Partials       650      650              
Flag Coverage Δ
uitests 60.16% <ø> (+9.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hughns hughns added the Trigger-PR-Build Label to trigger builds for PRs label May 26, 2025
Copy link

@hughns
Copy link
Member Author

hughns commented May 26, 2025

I'm not sure what the problem with CI is.

@hughns hughns marked this pull request as ready for review May 26, 2025 16:51
@Velin92 Velin92 merged commit 025199f into develop May 28, 2025
8 of 10 checks passed
@Velin92 Velin92 deleted the hughns/msc4286 branch May 28, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger-PR-Build Label to trigger builds for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants