Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Siri, Share and Reply (from NSE) Extensions. #7619

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

pixlwave
Copy link
Member

This PR disables the targets, but the code remains. And we no longer use QUICK_REPLY as a category on notifications.

Closes #7618.

@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pixlwave pixlwave requested review from a team, stefanceriu and aringenbach and removed request for a team and stefanceriu July 10, 2023 12:19
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.15 ⚠️

Comparison is base (9c8a8cf) 12.36% compared to head (b7e7c78) 12.21%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7619      +/-   ##
===========================================
- Coverage    12.36%   12.21%   -0.15%     
===========================================
  Files         1648     1648              
  Lines       163667   163667              
  Branches     67211    67195      -16     
===========================================
- Hits         20239    19996     -243     
- Misses      142763   143026     +263     
+ Partials       665      645      -20     
Flag Coverage Δ
unittests 6.06% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pixlwave pixlwave merged commit b4ebcc7 into develop Jul 12, 2023
17 checks passed
@pixlwave pixlwave deleted the doug/7618-disable-app-extensions branch July 12, 2023 09:26
csett86 pushed a commit to luki-ev/synod-ios that referenced this pull request Jul 15, 2023
@antdude
Copy link

antdude commented Aug 21, 2023

This is disappointing after I updated my iOS app today. I can no longer share from other iOS apps in my iPhone (iOS v16.6). I guess I will have to use other Matrix apps like FluffyChat. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable App Extensions impacted by multi-process race conditions
3 participants