Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement call list #5357

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

simonwiedmer
Copy link
Contributor

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

This pull-request shows the implementation of the call list on the aarenet specific fork.
It depends on matrix-org/matrix-ios-sdk#1307 for filtering for the PSTN (SIP) call rooms.

@langleyd langleyd self-requested a review March 4, 2022 11:43
Copy link
Contributor

@langleyd langleyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this new feature PR!

The PR needs an issue associated with it describing the feature and also a change log item. Would you mind checking out the contributing guidelines and updating?

Also I think this is a new feature so the issue should be marked X-Needs-Design and X-Needs-Product so that it gets product/design sign-off before inclusion.

@simonwiedmer
Copy link
Contributor Author

Created corresponding issue #5782

It seems like cannot add tags to the issue.

@simonwiedmer
Copy link
Contributor Author

corresponding issue in the SDK: matrix-org/matrix-ios-sdk#1396

@simonwiedmer simonwiedmer marked this pull request as draft March 10, 2022 15:06
@simonwiedmer
Copy link
Contributor Author

Btw, the failing compile check is because it depends on changes in the SDK (matrix-org/matrix-ios-sdk#1307)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants