Verify device has no effect

[manuroe]

Steps to reproduce:

• in the timeline of an e2e room, tap on the warning triangle on a message from a non verified device
• verify that device

-> 80% of the time, the warning triangle is still displayed, meaning the device has not been verified.
The issue persists after an app restart

[manuroe]

The bug comes from the introduction and the usage of [MXCryptoStore deviceWithIdentityKey:] method in matrix-org/matrix-ios-sdk@481623f.

This method is not buggy but it reveals that the way we store user devices is wrong and leads to device duplicates. This bug is at https://github.com/matrix-org/matrix-ios-sdk/blob/40989276f4519e157bdcb04589ef00fdf3fdb12b/MatrixSDK/Crypto/Data/Store/MXRealmCryptoStore/MXRealmCryptoStore.m#L479.

This bug was hidden and it worked fine when there is only one device getter method in the crypto store. With the new [MXCryptoStore deviceWithIdentityKey:], we make a different query that gets a different object but with the same data :/.