Skip to content

Add support for overlaying notification badges on the Windows Taskbar icon. #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Half-Shot merged 12 commits into from
Jul 18, 2025
Merged

Add support for overlaying notification badges on the Windows Taskbar icon. #2443

Half-Shot merged 12 commits into from
Jul 18, 2025

Conversation

@Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Jul 14, 2025 •
edited
Loading

Fixes #762
Requires element-hq/element-web#30315

This uses https://www.electronjs.org/docs/latest/api/browser-window#winsetoverlayiconoverlay-description-windows to add a badge to the taskbar icon on Windows to show how many outstanding notifications there are, or if the client goes offline.

2025-07-14.16-22-20.mp4

Checklist

  • Ensure your code works with manual testing.
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

t3chguy
t3chguy reviewed Jul 14, 2025
View reviewed changes
@Half-Shot Half-Shot mentioned this pull request Jul 14, 2025
Merged
4 tasks
@Half-Shot Half-Shot marked this pull request as ready for review July 14, 2025 13:32
@Half-Shot Half-Shot requested a review from a team as a code owner July 14, 2025 13:32
@Half-Shot Half-Shot requested review from dbkr and t3chguy July 14, 2025 13:32
@Half-Shot Half-Shot self-assigned this Jul 15, 2025
@Half-Shot Half-Shot requested a review from a team as a code owner July 15, 2025 12:55
t3chguy
t3chguy requested changes Jul 16, 2025
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we consolidate the setBadgeCount IPC & favicon event handling into one file badge.ts or something to make it clear that they are mutually exclusive?

@Half-Shot
Copy link
Member Author

Half-Shot commented Jul 17, 2025

Could we consolidate the setBadgeCount IPC & favicon event handling into one file badge.ts or something to make it clear that they are mutually exclusive?

Did my best with this. There is some overlap still with tray.ts, but I think this is quite clear now.

@Half-Shot Half-Shot requested a review from t3chguy July 17, 2025 13:01
t3chguy
t3chguy approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane otherwise

@Half-Shot Half-Shot enabled auto-merge July 18, 2025 07:23
@Half-Shot Half-Shot merged commit 229e52d into develop Jul 18, 2025
34 checks passed
@Half-Shot Half-Shot deleted the hs/add-support-for-windows-badges branch July 18, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t3chguy t3chguy t3chguy approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees

@Half-Shot Half-Shot

Labels

T-Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Number of unread messages badge not shown in the taskbar on Windows 10

3 participants

@Half-Shot @t3chguy