Skip to content

Conversation

@robintown
Copy link
Member

@robintown robintown commented Jul 24, 2025

0e0fba6 added the ability to send call notification events when starting a call, but I forgot to give the widget the right capabilities to do this. The effect was that notifications just wouldn't send in widget mode.

Auto-approval changes:

I will backport this once reviewed.

0e0fba6 added the ability to send call notification events when starting a call, but I forgot to give the widget the right capabilities to do this. The effect was that notifications just wouldn't send in widget mode.
Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want the notification to be sendrecv as well. A decline probably will also do sth inside EC.

You could argue that this is over eager since we currently dont work on it. Its very easy to do here and saves us a step if we eventually end up working on it.

@robintown
Copy link
Member Author

Didn't we agree that decline should be a different event type?

@toger5
Copy link
Contributor

toger5 commented Jul 28, 2025

Didn't we agree that decline should be a different event type?

We discussed it but I am not sure there was a conclusion yet. At least nothing that was captured in the MSC.

But the arguments were really strong. (Most of the fields are different so a new type make quiet a bit of sense)

Since the reading needs is not guaranteed based on whatever the outcome of this discussion when it happens would be. It does make sense to merge it like it is.

@robintown robintown merged commit ff3f727 into livekit Jul 28, 2025
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-candidate Something that is a candidate for backport to a particular release branch PR-Bug-Fix Release note category. A PR that fixes a bug. X-Release-Blocker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants