Skip to content

Fix Playwright tests #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: livekit
Choose a base branch
from

Conversation

fkwp
Copy link
Contributor

@fkwp fkwp commented May 27, 2025

Resolve port conflicts in docker-compose dev-backend-docker-compose.yml

  • Change JWT port to 6080 to not conflict with the playwright tests.

Adapt playwright element web fixture to work with the latex UX flows.

@fkwp fkwp requested a review from a team as a code owner May 27, 2025 14:34
@fkwp fkwp requested a review from AndrewFerr May 27, 2025 14:34
@fkwp fkwp added the PR-Bug-Fix Release note category. A PR that fixes a bug. label May 27, 2025
@fkwp fkwp changed the title Resolve port conflicts in docker-compose dev-backend-docker-compose.yml Fix Playwright tests May 27, 2025
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, the tests aren't actually fixed…

@@ -127,6 +134,13 @@ export const widgetTest = test.extend<MyFixtures>({
.getByRole("textbox", { name: "Confirm password" })
.fill(PASSWORD);
await ewPage2.getByRole("button", { name: "Register" }).click();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The registration & account setup of user 1 and user 2 looks like it could benefit from being extracted into a function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bug-Fix Release note category. A PR that fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants