Fix creating two lk rooms if there is no local store setup (fixes a resulting disconnect bug) #3293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
force-pushed
the
toger5/more-disconnect-logging
branch
from
553f67d to
a1110af
Compare
toger5
changed the title
BillCarsonFr
approved these changes
May 27, 2025
| @@ -29,7 +29,7 @@ window.setLKLogLevel = setLKLogLevel; | |||
| initRageshake().catch((e) => { | |||
| logger.error("Failed to initialize rageshake", e); | |||
| }); | |||
| setLKLogLevel("warn"); | |||
| setLKLogLevel("info"); | |||
There was a problem hiding this comment.
Agree, info is engouh to get the livekit room logs we want
toger5
added a commit
that referenced
this pull request
May 28, 2025
Fix creating two lk rooms if there is no local store setup (fixes a resulting disconnect bug)
toger5
added a commit
that referenced
this pull request
May 28, 2025
…ng (#3297) Fix creating two lk rooms if there is no local store setup (fixes a resulting disconnect bug)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.