-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add developer mode option to show RTC connection statistics #2904
Conversation
b2aeeb8
to
6f4d5a7
Compare
Could be the tooltip provider? |
Good spot. It's the same on Chrome too. |
I've moved the detailed data into a modal and I think it's probably good enough for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is hard to tell how much time and effort we want to put into this.
There are a couple of issues:
your own stream does not show reasonable data:
The styling is hard to read, the buttons are super small.
But I suspect this is just debug information and should not be used by users who want EC to be pretty.
I will give it a quick try to change the css to be a bit more fitting and you can check if you like it.
Here are the proposed changes: #2916 |
(React rendered 0 instead of <Text /> for fps && <Text>{fps}</text>)
Answer: Not a lot of effort. This was intended to surface easily accessible information. As this isn't a full feature this is fine for now. If/when we want own stats for debugging then we can wire more of them in.
I've merged your proposal 👍 |
New option in developer settings:
Which overlays some basic info on audio and video when available:
And you can click to get the full
RTCInboundRtpStreamStats | RTCOutboundRtpStreamStats
data in a modal: