Support selection of audio output device when using Firefox #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Managing your audio output manually is kind of cumbersome; Chrome creates a default audio output for us, but now that audio outputs are enabled on Firefox as well, I find it necessary for a good user experience that there always be a way to set it to "whatever the default is".
robintown
force-pushed
the
firefox-audio-output
branch
from
ffa6dca to
f249b7d
Compare
toger5
reviewed
Nov 26, 2024
|
@robintown are you planning on working on this more or should it be moved to draft? |
|
Doing a bit of work on this now. |
|
It looks like this now:
|
|
Hmm, I'm curious why the code coverage upload isn't working here. Codecov appears confused about whether my branch is protected or not (it isn't) |
|
https://github.com/element-hq/it-internal/issues/1784 for the coverage upload error |
hughns
changed the title
hughns
approved these changes
Dec 16, 2024
|
Do you still have reactivity on your os's? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issues we originally saw with audio outputs on Firefox seem to be resolved. Let's re-enable this while also giving Firefox users a way to make their audio output follow the system default, like Chrome does out of the box.
Closes #2022