Set LiveKit keyring size to 256 #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkwp
approved these changes
Oct 4, 2024
The default is 16 which doesn't match what we expect.
hughns
force-pushed
the
hughns/lk-keyringsize
branch
from
7cc736a to
933f128
Compare
hughns
force-pushed
the
hughns/lk-keyringsize
branch
from
933f128 to
dc96a5b
Compare
|
n.b. i pulled the tests out of this and in to #2646 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default is 16 which doesn't match what we expect.
We will need to upgrade the LiveKit client before this merges because we need livekit/client-sdk-js#1268.