Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing client store (caused by: #2587) #2591

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Aug 30, 2024

No description provided.

@toger5 toger5 requested a review from a team as a code owner August 30, 2024 08:37
@toger5 toger5 changed the title Fix for missing client store (caused by: #2587) @toger5 Fix for missing client store (caused by: #2587) Aug 30, 2024
@toger5 toger5 force-pushed the toger5/fix-rust-crypto branch from 71633d4 to f33dde5 Compare August 30, 2024 08:44
@@ -139,7 +139,21 @@ export async function initClient(
client.clearStores();
}

// start the client store (totally independent to the crypto store)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// start the client store (totally independent to the crypto store)
// start client store
// Note client.store is used to stash things like sync results. It's totally independent of the cryptostore, and uses a separate indexeddb database.

Copy link
Contributor

@fkwp fkwp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@toger5 toger5 force-pushed the toger5/fix-rust-crypto branch from f33dde5 to c3b96d1 Compare August 30, 2024 08:56
@toger5 toger5 merged commit a2dd538 into livekit Aug 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants