Make js-sdk imports consistent #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to be consistent about whether we import matrix-js-sdk from `src` or `lib`, otherwise we get two copies of matrix-js-sdk, and everything explodes.
richvdh
force-pushed
the
rav/fix_js_sdk_imports
branch
from
e933bb6 to
354086c
Compare
AndrewFerr
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be consistent about whether we import matrix-js-sdk from
srcorlib, otherwise we get two copies of matrix-js-sdk, and everything explodes.This fixes a long-standing bug which meant that element-call couldn't be successfully built against release versions of matrix-js-sdk. That bug recently became more acute due to matrix-org/matrix-js-sdk#4357, which brought non-release versions of matrix-js-sdk into line with release versions.