Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct DOM event name for visibility changes in useWakeLock #2435

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

hughns
Copy link
Member

@hughns hughns commented Jun 19, 2024

The event should be visibilitychange not visiblitychange as per https://developer.mozilla.org/en-US/docs/Web/API/Document/visibilitychange_event.

I haven't tested this, but I assume that it means the useWakeLock doesn't work as intended today.

Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find.

Changes look super straight forward

@robintown robintown merged commit f9ef037 into livekit Jun 20, 2024
3 checks passed
@hughns hughns deleted the hughns/visibilitychange branch August 12, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants