Skip to content

Commit

Permalink
remove error for unencrypted calls (allow intentional unencrypted calls)
Browse files Browse the repository at this point in the history
Signed-off-by: Timo K <toger5@hotmail.de>
  • Loading branch information
toger5 committed Apr 22, 2024
1 parent be299d0 commit 90e5efe
Showing 1 changed file with 2 additions and 17 deletions.
19 changes: 2 additions & 17 deletions src/room/GroupCallView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -291,23 +291,8 @@ export const GroupCallView: FC<Props> = ({

const { t } = useTranslation();

if (e2eeSystem.kind === E2eeType.NONE && !widget) {
// the url wants encryption, but we don't have a encryption system. (e.g. when joining a call without password)
// TODO: we need to figure out what we do with encryption going forward.
// In the SPA a room is unencrypted but uses a shared secret for the call (since we distribute via url that works)
// In embedded mode unencrypted rooms would make most sense to also call unencrypted.
// A call where one person joins with the spa and another person with the widget would be a problem.
return (
<ErrorView
error={
new Error(
`No E2EE key or other encryption system provided: ${import.meta.env.VITE_PRODUCT_NAME || "Element Call"} calls are always encrypted. Please make sure the URL you're using to join this call has been retrieved using the in-app button.`,
)
}
/>
);
} else if (!isE2EESupportedBrowser()) {
// and we have a encryption system.
if (!isE2EESupportedBrowser() && e2eeSystem.kind !== E2eeType.NONE) {
// If we have a encryption system but the browser does not support it.
return (
<FullScreenView>
<Heading>{t("browser_media_e2ee_unsupported_heading")}</Heading>
Expand Down

0 comments on commit 90e5efe

Please sign in to comment.