Add user completion for matrix ids #8271

yostyle · 2023-03-23T13:53:53Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Add user completion for matrix ids

Motivation and context

#8217

Screenshots / GIFs

Tests

Step 1
Step 2
Step ...

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

Florian14 · 2023-03-24T09:18:55Z

vector/src/main/java/im/vector/app/features/autocomplete/member/AutocompleteMemberPresenter.kt

+                    .filter { roomMemberSummary ->
+                        query?.let {
+                            it.isBlank() || roomMemberSummary.displayName?.contains(it, true).orFalse() || roomMemberSummary.userId.contains(it, true)
+                        }.orTrue()
+                    }


I'm wondering if it's better to add the filter on the resulting list or in the realm query, something like this should work:

override fun getRoomMembers(queryParams: RoomMemberQueryParams, query: String): List<RoomMemberSummary> { return monarchy.fetchAllMappedSync( { roomMembersQuery(it, queryParams) .and() .contains(RoomMemberSummaryEntityFields.USER_ID, query) .or() .contains(RoomMemberSummaryEntityFields.DISPLAY_NAME, query) }, { it.asDomain() } ) }

WDYT?