Skip to content

create encrypted DM for user invite by email #8172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 6, 2023

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Feb 24, 2023

@yostyle yostyle requested review from a team, jonnyandrew and giomfo and removed request for a team February 24, 2023 17:49
@yostyle yostyle force-pushed the yostyle/create_dm_by_email branch from 2e49def to fb5732f Compare February 28, 2023 00:50
@yostyle yostyle marked this pull request as ready for review February 28, 2023 14:18
@yostyle yostyle force-pushed the yostyle/create_dm_by_email branch from 3466501 to df4824c Compare March 3, 2023 15:10
@giomfo
Copy link
Member

giomfo commented Mar 3, 2023

@yostyle I did some additional tests the changes prevent the end users from inviting email and matrix id at the same time in an existing room
image

Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all test ok.
Please wait for all platforms to be ready before merging this PR

@yostyle yostyle force-pushed the yostyle/create_dm_by_email branch from e4a07c8 to b217ec5 Compare March 6, 2023 10:27
@yostyle yostyle added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Mar 6, 2023
@yostyle yostyle enabled auto-merge (squash) March 6, 2023 11:20
@yostyle yostyle disabled auto-merge March 6, 2023 15:30
@yostyle yostyle force-pushed the yostyle/create_dm_by_email branch from c94228c to 2e71730 Compare March 6, 2023 15:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@yostyle yostyle merged commit 94675b9 into develop Mar 6, 2023
@yostyle yostyle deleted the yostyle/create_dm_by_email branch March 6, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants