Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search tests #7558

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Fix search tests #7558

merged 2 commits into from
Nov 9, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 9, 2022

Synapse is not returning result for incomplete word anymore.

This PR take into account this change.

A new test is added to check this new behavior about incomplete word.

Maybe related to recent change on Synapse 1.71.0: https://github.com/matrix-org/synapse/releases/tag/v1.71.0 :

Allow use of Postgres and SQLlite full-text search operators in search queries. (matrix-org/synapse#11635, matrix-org/synapse#14310, matrix-org/synapse#14311)

No need for a changelog.

@bmarty bmarty requested review from a team and onurays and removed request for a team November 9, 2022 14:34
Copy link
Contributor

@onurays onurays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Sad to see the this functionality change)

@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bmarty bmarty merged commit 7227a83 into develop Nov 9, 2022
@bmarty bmarty deleted the feature/bma/fix_search_tests branch November 9, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants