Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporary workaround for a failing sync due to unexpected `enableUnre… #7534

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

fedrunov
Copy link
Contributor

@fedrunov fedrunov commented Nov 7, 2022

…adThreadNotifications` param

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

passing unread_thread_notifications for a sync filter cause sync to fail if synapse doesn't support 1.4 spec

Motivation and context

related issue: #7516

this PR won't close issue since it's temporary fix to unblock relase

@fedrunov fedrunov requested a review from bmarty November 7, 2022 15:20
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will cherry pick to create a hotfix release.

@bmarty bmarty merged commit 76d3050 into develop Nov 7, 2022
@bmarty bmarty deleted the bugfix/nfe/unexpected_sync_param branch November 7, 2022 16:06
@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants