QR Code Login UI #7338

onurays · 2022-10-11T17:05:01Z

Type of change

Feature
Bugfix
Technical
Other :

Content

New screens for signing in by scanning a QR code. This PR does not include the logic to do the login. This logic is in a separate PR: #7369

Motivation and context

The goal is to make signing in and set up of E2EE Element Android simpler in the case that the user already has an active session on another (capable) device.

The capability is behind a feature flag and also requires a compatible homeserver.

The "Show QR Code Login in Device Manager" is in preparation for the next phase of development of this feature.

Screenshots / GIFs

On enabling the feature and entering a homeserver (or choosing to show for all homeservers) a new button is visible:

On press it you get some instructions:

After this the new screens show in a carousel instead of being attached to real logic.

Tests

Step 1
Step 2
Step ...

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

# Conflicts: # library/ui-strings/src/main/res/values/strings.xml # library/ui-styles/src/main/res/values/stylable_sessions_list_header_view.xml # vector-app/src/debug/java/im/vector/app/features/debug/features/DebugFeaturesStateFactory.kt # vector-app/src/debug/java/im/vector/app/features/debug/features/DebugVectorFeatures.kt # vector/src/main/java/im/vector/app/core/di/MavericksViewModelModule.kt # vector/src/main/java/im/vector/app/features/VectorFeatures.kt # vector/src/main/java/im/vector/app/features/settings/devices/v2/VectorSettingsDevicesFragment.kt # vector/src/main/java/im/vector/app/features/settings/devices/v2/list/SessionsListHeaderView.kt # vector/src/main/res/layout/fragment_other_sessions.xml # vector/src/main/res/layout/fragment_settings_devices.xml

…tor-im/element-android into feature/ons/qr_code_login_ui

ElementBot · 2022-10-14T15:12:59Z

	Warnings
⚠️	vector/src/main/AndroidManifest.xml#L200 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L200 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L203 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L203 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L257 - Expecting `android:screenOrientation="unspecified"` or `"fullSensor"` for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
⚠️	vector/src/main/AndroidManifest.xml#L257 - Expecting `android:screenOrientation="unspecified"` or `"fullSensor"` for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
⚠️	vector/src/main/AndroidManifest.xml#L266 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L266 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L273 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L273 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L279 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L279 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L399 - Exported receiver does not require permission
⚠️	vector/src/main/AndroidManifest.xml#L399 - Exported receiver does not require permission
⚠️	vector/src/main/res/drawable/ic_qr_code.xml#L7 - Very long vector path (1366 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.
⚠️	vector/src/main/res/drawable/ic_qr_code.xml#L7 - Very long vector path (1366 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.
⚠️	vector/src/main/res/drawable/ic_qr_code_login_connected.xml#L7 - Very long vector path (814 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.
⚠️	vector/src/main/res/drawable/ic_qr_code_login_connected.xml#L7 - Very long vector path (814 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.
⚠️	vector/src/main/res/layout/fragment_ftue_combined_login.xml#L7 - Possible overdraw: Root element paints background `?android:colorBackground` with a theme that also paints a background (inferred theme is `@android:style/Theme.Holo`)
⚠️	vector/src/main/res/layout/fragment_ftue_combined_login.xml#L7 - Possible overdraw: Root element paints background `?android:colorBackground` with a theme that also paints a background (inferred theme is `@android:style/Theme.Holo`)
⚠️	vector/src/main/res/layout/fragment_qr_code_login_show_qr_code.xml#L7 - Possible overdraw: Root element paints background `?android:colorBackground` with a theme that also paints a background (inferred theme is `@android:style/Theme.Holo`)
⚠️	vector/src/main/res/layout/fragment_qr_code_login_show_qr_code.xml#L7 - Possible overdraw: Root element paints background `?android:colorBackground` with a theme that also paints a background (inferred theme is `@android:style/Theme.Holo`)
⚠️	vector/src/main/res/layout/fragment_qr_code_login_status.xml#L7 - Possible overdraw: Root element paints background `?android:colorBackground` with a theme that also paints a background (inferred theme is `@android:style/Theme.Holo`)
⚠️	vector/src/main/res/layout/fragment_qr_code_login_status.xml#L7 - Possible overdraw: Root element paints background `?android:colorBackground` with a theme that also paints a background (inferred theme is `@android:style/Theme.Holo`)

Generated by 🚫 dangerJS against d3a24fe

mnaturel · 2022-10-14T15:22:57Z

...ain/java/org/matrix/android/sdk/internal/session/homeserver/GetHomeServerCapabilitiesTask.kt

@@ -144,6 +143,9 @@ internal class DefaultGetHomeServerCapabilitiesTask @Inject constructor(
            if (getVersionResult != null) {
                homeServerCapabilitiesEntity.lastVersionIdentityServerSupported = getVersionResult.isLoginAndRegistrationSupportedBySdk()
                homeServerCapabilitiesEntity.canControlLogoutDevices = getVersionResult.doesServerSupportLogoutDevices()
+                homeServerCapabilitiesEntity.canUseThreading = /* capabilities?.threads?.enabled.orFalse() || */
+                        getVersionResult.doesServerSupportThreads().orFalse()


Minor but orFalse() seem not needed anymore here.

Right, done.

mnaturel · 2022-10-14T15:29:49Z

vector/src/main/java/im/vector/app/features/login/qr/QrCodeLoginAction.kt

+
+sealed class QrCodeLoginAction : VectorViewModelAction {
+    data class OnQrCodeScanned(val qrCode: String) : QrCodeLoginAction()
+    object QrCodeViewStarted : QrCodeLoginAction()


Could we rename QrCodeViewStarted to GenerateQrCode so that it reflects more the action we really want to perform?

Good suggestion, done.

mnaturel · 2022-10-14T15:39:55Z

vector/src/main/java/im/vector/app/features/login/qr/QrCodeLoginHeaderView.kt

+        binding.qrCodeLoginHeaderImageView.backgroundTintList = ColorStateList.valueOf(backgroundTint)
+    }
+
+    fun setTitle(title: String) {


Could we reuse the public methods inside the private ones to replace part of their implementation? For instance calling setTitle(title) instead of binding.qrCodeLoginHeaderTitleTextView.text = title.

mnaturel · 2022-10-14T15:45:57Z

vector/src/main/java/im/vector/app/features/login/qr/QrCodeLoginInstructionsFragment.kt

+    }
+
+    private fun observeViewState() {
+        viewModel.onEach {


Why not using the invalidate() method here to react to change of viewState?

I was about to ask the same thing :)

Oh, I totally forgot this function, done.

mnaturel · 2022-10-14T15:48:38Z

vector/src/main/java/im/vector/app/features/login/qr/QrCodeLoginInstructionsFragment.kt

+    }
+
+    private fun onQrCodeScannerFailed() {
+        Timber.d("QrCodeLoginInstructionsFragment.onQrCodeScannerFailed")


Should we prompt the user about the error in this case?

Hugh is implementing it in another PR.

mnaturel · 2022-10-14T16:04:52Z

vector/src/main/java/im/vector/app/features/login/qr/QrCodeLoginInstructionsView.kt

+        binding.instructions1Layout.isVisible = instruction1 != null
+        binding.instructions2Layout.isVisible = instruction2 != null
+        binding.instructions3Layout.isVisible = instruction3 != null
+        binding.instruction1TextView.text = instruction1


Maybe we could use our extension method: setTextOrHide? And setInstructions(instructions: List<String>) could be called here instead, I think.

mnaturel · 2022-10-14T16:06:26Z

vector/src/main/java/im/vector/app/features/login/qr/QrCodeLoginInstructionsView.kt

+    }
+
+    private fun setInstruction(instructionLayout: LinearLayout, instructionTextView: TextView, instruction: String?) {
+        instruction?.let {


I guess we could use our extension method: setTextOrHide.

Not really, because the layout visibility has to change, not the TextView visibility

Oh you are right, I have read it too fast.

bmarty

Not a lot to say after @mnaturel review, just some minor remarks. Nice work!

bmarty · 2022-10-14T16:13:37Z

library/ui-strings/src/main/res/values/strings.xml

+    <string name="qr_code_login_header_failed_denied_description">The request was denied on the other device.</string>
+    <string name="qr_code_login_new_device_instruction_1">Open ${app_name} on your other device</string>
+    <string name="qr_code_login_new_device_instruction_2">Go to Settings -> Security &amp; Privacy -> Show All Sessions</string>
+    <string name="qr_code_login_new_device_instruction_3">Select \'Show QR code\'</string>


Maybe to avoid translation mistake, change to

Suggested change

<string name="qr_code_login_new_device_instruction_3">Select \'Show QR code\'</string>

<string name="qr_code_login_new_device_instruction_3">Select \'%s\'</string>

and inject at runtime the wording of the button.
Which is the key qr_code_login_show_qr_code_button IIUC which contains the text... Show QR code in this device.

bmarty · 2022-10-14T16:16:47Z

vector/src/main/java/im/vector/app/features/onboarding/OnboardingViewModel.kt

+            }
+        } else {
+            // check if selected server supports MSC3882 first
+            homeServerConnectionConfigFactory.create(homeServerUrl)?.let {


Maybe use the block viewModelScope.launch { only here?

Right, done.

bmarty · 2022-10-14T16:19:06Z

...k-android/src/main/java/org/matrix/android/sdk/internal/auth/DefaultAuthenticationService.kt

+                authAPI.versions()
+            }
+        }
+        return if (versions.isSuccess) {


If there is a network error the client will consider that the feature is not supported (which is maybe acceptable here).

I think it is ok to silently hide it on network problems.

bmarty · 2022-10-14T16:24:15Z

vector/src/main/java/im/vector/app/features/login/qr/QrCodeLoginActivity.kt

+                }
+                null -> {
+                    Timber.i("QrCodeLoginArgs is null. This is not expected.")
+                    finish()


Maybe also add a return statement to avoid calling observeViewEvents

Right, done.

bmarty · 2022-10-14T16:28:27Z

vector/src/main/java/im/vector/app/features/login/qr/QrCodeLoginInstructionsView.kt

+    }
+
+    private fun setInstruction(instructionLayout: LinearLayout, instructionTextView: TextView, instruction: String?) {
+        instruction?.let {


Not really, because the layout visibility has to change, not the TextView visibility

bmarty · 2022-10-14T16:37:54Z

vector/src/main/java/im/vector/app/features/login/qr/QrCodeLoginArgs.kt

+@Parcelize
+data class QrCodeLoginArgs(
+        val loginType: QrCodeLoginType,
+        val showQrCodeByDefault: Boolean,


Maybe rename to showQrCodeImmediately?

Make sense, done.

bmarty · 2022-10-14T16:38:29Z

vector/src/main/java/im/vector/app/features/login/qr/QrCodeLoginActivity.kt

+                    showInstructionsFragment(qrCodeLoginArgs)
+                }
+                QrCodeLoginType.LINK_A_DEVICE -> {
+                    if (qrCodeLoginArgs.showQrCodeByDefault.orFalse()) {


orFalse() is not needed here.

Right, done.

bmarty · 2022-10-14T16:40:07Z

...or/src/main/java/im/vector/app/features/settings/devices/v2/VectorSettingsDevicesFragment.kt

+                                    showQrCodeByDefault = true,
+                            )
+                    )
+        }


Maybe extract to a sub method to avoid code duplication:

private fun navigateToQrCodeScreen(showQrCodeImmediately: Boolean) { navigator .openLoginWithQrCode( requireActivity(), QrCodeLoginArgs( loginType = QrCodeLoginType.LINK_A_DEVICE, showQrCodeByDefault = showQrCodeImmediately, ) ) }

Or better you can expose it inside the VectorSettingsDevicesViewNavigator so that we can test it.

Done (didn't have time to create a standalone navigator, will do when we start writing tests for this feature).

The navigator was already in place for info, the idea was just to move the method inside it.

bmarty · 2022-10-14T16:41:16Z

vector/src/main/res/layout/fragment_ftue_combined_login.xml

+            app:drawableLeftCompat="@drawable/ic_qr_code"
+            app:layout_constraintEnd_toEndOf="@id/loginGutterEnd"
+            app:layout_constraintStart_toStartOf="@id/loginGutterStart"
+            app:layout_constraintTop_toBottomOf="@id/ssoButtonsHeader" />


Maybe hide by default to avoid blinking.

bmarty · 2022-10-14T16:45:52Z

vector/src/main/res/layout/view_qr_code_login_instructions.xml

+            android:background="@drawable/circle_qr_code_login_instruction_with_border"
+            android:padding="6dp"
+            android:text="@string/four"
+            android:textColor="?colorPrimary" />


There is no instruction4TextView?

Yep, design changed. Removed.

hughns · 2022-10-16T12:38:25Z

vector/src/main/java/im/vector/app/features/login/qr/QrCodeLoginStatusFragment.kt

+
+    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
+        super.onViewCreated(view, savedInstanceState)
+        initCancelButton()


The "try again" button also needs to be initialised.

Can you implement it in your PR?

mnaturel · 2022-10-17T07:55:07Z

vector/src/main/java/im/vector/app/features/login/qr/QrCodeLoginViewModel.kt

+            _viewEvents.post(QrCodeLoginViewEvents.NavigateToStatusScreen)
+        }
+
+        // TODO. UI test purpose. Fixme remove!


Is it supposed to be remove in this PR?

Now the onFailed, onConnectionEstablished and onSigninIn methods are not used, is it expected?

It is expected as the use of them is in #7369

mnaturel · 2022-10-17T07:56:11Z

vector/src/main/java/im/vector/app/features/login/qr/QrCodeLoginViewModel.kt

+    }
+
+    /**
+     * TODO. UI test purpose. Fixme accordingly.


Same question, will it be implemented later?

Yes, but I want to keep placeholder functions.

mnaturel · 2022-10-17T08:01:57Z

vector/src/main/java/im/vector/app/features/onboarding/OnboardingViewModel.kt

@@ -118,6 +118,33 @@ class OnboardingViewModel @AssistedInject constructor(
        }
    }

+    private fun observeQrCodeLoginCapability(homeServerUrl: String) = viewModelScope.launch {


Why is method named with observe prefix? It seems there is no observation pattern. Here, I would rather name it checkQrCodeLoginCapability or refreshQrCodeLoginCapability.

mnaturel · 2022-10-17T08:03:43Z

...or/src/main/java/im/vector/app/features/onboarding/ftueauth/FtueAuthCombinedLoginFragment.kt

@@ -70,6 +74,28 @@ class FtueAuthCombinedLoginFragment :
            viewModel.handle(OnboardingAction.UserNameEnteredAction.Login(views.loginInput.content()))
        }
        views.loginForgotPassword.debouncedClicks { viewModel.handle(OnboardingAction.PostViewEvent(OnboardingViewEvents.OnForgetPasswordClicked)) }
+
+        viewModel.onEach(OnboardingViewState::canLoginWithQrCode) {


Maybe to be moved inside invalidate method?

Not possible probably since this is an abstract class.

It is because the invalidate method has been declared final in the AbstractFtueAuthFragment. I wonder why it has been declared final.

mnaturel · 2022-10-17T08:10:38Z

vector/src/main/res/drawable/ic_qr_code.xml

+    android:viewportWidth="13"
+    android:viewportHeight="12">
+  <path
+      android:pathData="M7.167,12V10.667H8.5V12H7.167ZM5.833,10.667V7.333H7.167V10.667H5.833ZM11.167,8.667V6H12.5V8.667H11.167ZM9.833,6V4.667H11.167V6H9.833ZM1.833,7.333V6H3.167V7.333H1.833ZM0.5,6V4.667H1.833V6H0.5ZM6.5,1.333V0H7.833V1.333H6.5ZM1.333,3.167H3.667V0.833H1.333V3.167ZM1,4C0.856,4 0.736,3.953 0.642,3.858C0.547,3.764 0.5,3.644 0.5,3.5V0.5C0.5,0.356 0.547,0.236 0.642,0.142C0.736,0.047 0.856,0 1,0H4C4.144,0 4.264,0.047 4.358,0.142C4.453,0.236 4.5,0.356 4.5,0.5V3.5C4.5,3.644 4.453,3.764 4.358,3.858C4.264,3.953 4.144,4 4,4H1ZM1.333,11.167H3.667V8.833H1.333V11.167ZM1,12C0.856,12 0.736,11.953 0.642,11.858C0.547,11.764 0.5,11.644 0.5,11.5V8.5C0.5,8.356 0.547,8.236 0.642,8.142C0.736,8.047 0.856,8 1,8H4C4.144,8 4.264,8.047 4.358,8.142C4.453,8.236 4.5,8.356 4.5,8.5V11.5C4.5,11.644 4.453,11.764 4.358,11.858C4.264,11.953 4.144,12 4,12H1ZM9.333,3.167H11.667V0.833H9.333V3.167ZM9,4C8.856,4 8.736,3.953 8.642,3.858C8.547,3.764 8.5,3.644 8.5,3.5V0.5C8.5,0.356 8.547,0.236 8.642,0.142C8.736,0.047 8.856,0 9,0H12C12.144,0 12.264,0.047 12.358,0.142C12.453,0.236 12.5,0.356 12.5,0.5V3.5C12.5,3.644 12.453,3.764 12.358,3.858C12.264,3.953 12.144,4 12,4H9ZM9.833,12V10H8.5V8.667H11.167V10.667H12.5V12H9.833ZM7.167,7.333V6H9.833V7.333H7.167ZM4.5,7.333V6H3.167V4.667H7.167V6H5.833V7.333H4.5ZM5.167,4V1.333H6.5V2.667H7.833V4H5.167ZM2,2.5V1.5H3V2.5H2ZM2,10.5V9.5H3V10.5H2ZM10,2.5V1.5H11V2.5H10Z"


The path seems long for this icon. I think we may either use the PNG version or reduce the complexity using a tool like https://github.com/alexjlockwood/avocado

mnaturel · 2022-10-17T08:11:19Z

vector/src/main/res/drawable/ic_qr_code_login_connected.xml

+    android:viewportWidth="54"
+    android:viewportHeight="38">
+  <path
+      android:pathData="M53.667,19C53.667,17.533 52.467,16.333 51,16.333H45.48C44.173,7.293 36.413,0.333 27,0.333C17.587,0.333 9.827,7.293 8.52,16.333H3C1.533,16.333 0.333,17.533 0.333,19C0.333,20.467 1.533,21.667 3,21.667H8.52C9.827,30.707 17.587,37.667 27,37.667C36.413,37.667 44.173,30.707 45.48,21.667H51C52.467,21.667 53.667,20.467 53.667,19ZM35,25.667C35,27.133 33.8,28.333 32.333,28.333H21.667C20.2,28.333 19,27.133 19,25.667V17.667C19,16.2 20.2,15 21.667,15V12.333C21.667,9.107 24.547,6.52 27.907,7.08C30.52,7.507 32.333,9.96 32.333,12.627V15C33.8,15 35,16.2 35,17.667V25.667ZM29,21.667C29,22.76 28.093,23.667 27,23.667C25.907,23.667 25,22.76 25,21.667C25,20.573 25.907,19.667 27,19.667C28.093,19.667 29,20.573 29,21.667ZM29.667,12.333V15H24.333V12.333C24.333,10.867 25.533,9.667 27,9.667C28.467,9.667 29.667,10.867 29.667,12.333Z"


Same remark for the complexity of the path here.

mnaturel

@onurays Could you fill the PR description? I have tried to test it but I could not see any QR code login UI even when I use a server which is supposed to support it. I guess this is due to the fact we are currently using build flags?

mnaturel · 2022-10-17T10:02:21Z

After some testings between 2 Android devices (did not find the QR code options in Web session), here is what I have seen:

Instruction 2 of the "Scan QR code" screen includes a path to settings: perhaps this path is not valid for Web session an maybe iOS session too?
I have got an error screen saying "Unsuccessful connection: Linking with this device is not supported", I have seen it before and after a screen saying the connection has been established. Seems related to the UI tests I have seen in TODO in the QrCodeLoginViewModel.

hughns · 2022-10-17T11:41:51Z

After some testings between 2 Android devices (did not find the QR code options in Web session), here is what I have seen:

Instruction 2 of the "Scan QR code" screen includes a path to settings: perhaps this path is not valid for Web session an maybe iOS session too?

It will be valid for web soon where feature has been enabled. iOS support will come later.

Given the constraints of rolling out this feature across platforms I think it is acceptable for the wording to be slightly unclear whilst it is behind a feature flag.

I have got an error screen saying "Unsuccessful connection: Linking with this device is not supported", I have seen it before and after a screen saying the connection has been established. Seems related to the UI tests I have seen in TODO in the QrCodeLoginViewModel.

The implementation of the logic is in a separate PR: #7369

The plan is to get the UI merged in the current PR and then apply the logic PR.

mnaturel

Okay for me. There are some remaining non blocking comments that should be fixed later.

sonarcloud · 2022-10-17T14:12:15Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

15.3% Coverage
0.0% Duplication

bmarty · 2022-10-18T08:27:43Z

Thanks for the update.

For future reference, this comment has been ignored: #7338 (comment)

hughns · 2022-10-18T11:52:58Z

For future reference, this comment has been ignored: #7338 (comment)

This comment has now been followed up in #7369 (comment).

Onuray Sahin and others added 25 commits October 3, 2022 13:55

Create base classes.

06c0d61

Create custom view for header section.

6fbdd87

Create custom view for instructions section.

4fdb4e8

Complete qr code login instructions screen.

9859dab

Navigate to the instructions screen.

5f6c8ee

Remove unused session parameter.

5dfaa25

Navigate to qr code scanner activity.

9b7f6c9

Create qr code login status view layout.

945fa0a

Add connection status to the view state.

a66b183

Simulate qr login states.

a00afa7

Fix instructions view visibility.

1932eda

Implement show qr code screen.

04fb316

Fix cancel actions.

2527cab

Implement qr code login failed states.

2b452d6

Fix ui test case.

236b303

Refactor layout.

ad208a0

Refactor layout.

aacf2ba

Add qr code options to layout.

5566300

Implement link a device flow.

f272e56

Add flag for qr code login.

d8ea9c8

Retry scanning if not a QR code

87956e9

Implementations of MSC3886 and MSC3903

1235db7

Partial implementation of QR login logic

4b14ee4

Only do completeOnNewDevice if we received a confirmation code

6e58f2f

hughns mentioned this pull request Oct 13, 2022

MSC3906: Mechanism to allow sign in and E2EE set up via QR code matrix-org/matrix-spec-proposals#3906

Closed

6 tasks

onurays force-pushed the feature/ons/qr_code_login_ui branch 2 times, most recently from e1a8226 to d8ea9c8 Compare October 13, 2022 15:28

Onuray Sahin and others added 2 commits October 13, 2022 20:33

Cherry pick previous commits.

fb2776d

Merge branch 'feature/ons/qr_code_login_ui' of https://github.com/vec…

e554b43

…tor-im/element-android into feature/ons/qr_code_login_ui

onurays requested a review from mnaturel October 14, 2022 15:10

mnaturel reviewed Oct 14, 2022

View reviewed changes

bmarty reviewed Oct 14, 2022

View reviewed changes

hughns reviewed Oct 16, 2022

View reviewed changes

mnaturel reviewed Oct 17, 2022

View reviewed changes

Enable qr code login by default.

8547fee

Code review fixes.

91bb86d

onurays requested a review from mnaturel October 17, 2022 11:16

mnaturel approved these changes Oct 17, 2022

View reviewed changes

Lint fix.

d3a24fe

onurays merged commit 47c8714 into develop Oct 17, 2022

onurays deleted the feature/ons/qr_code_login_ui branch October 17, 2022 14:20

	<string name="qr_code_login_new_device_instruction_3">Select \'Show QR code\'</string>
	<string name="qr_code_login_new_device_instruction_3">Select \'%s\'</string>

QR Code Login UI #7338

QR Code Login UI #7338

Conversation

onurays commented Oct 11, 2022 • edited by hughns Loading

Type of change

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

ElementBot commented Oct 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mnaturel Oct 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mnaturel Oct 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mnaturel Oct 17, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mnaturel left a comment

Choose a reason for hiding this comment

mnaturel commented Oct 17, 2022

hughns commented Oct 17, 2022

mnaturel left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Oct 17, 2022

bmarty commented Oct 18, 2022

hughns commented Oct 18, 2022 • edited Loading

onurays commented Oct 11, 2022 •

edited by hughns

Loading

ElementBot commented Oct 14, 2022 •

edited

Loading

mnaturel Oct 14, 2022 •

edited

Loading

mnaturel Oct 14, 2022 •

edited

Loading

mnaturel Oct 17, 2022 •

edited

Loading

hughns commented Oct 18, 2022 •

edited

Loading