Missing fdroid notifications

[ouchadam]

Fixes #5003 Fdroid notifications no longer working.

The workaround is to switch the background mode to optimised for realtime

• We've had a small regression in the automatic background sync worker where the periodic flag was no longer being set and instead using the default value of false
• The named arguments should help combat this in the future!

https://github.com/vector-im/element-android/pull/4614/files#diff-0b0656b4f8d1f73f2a4d5844acec8bf35b732e315e5355800f74145c7fc82fa1L117

[bmarty]

Good catch, thanks!

[bmarty]

I am not that sure that they can be side effect. I will read it again.

[bmarty]

(Not sure how to revert approval)

[github-actions]

Unit Test Results

  72 files  ±0    72 suites  ±0   1m 2s ⏱️ +13s
141 tests ±0  141 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
440 runs  ±0  440 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2813048. ± Comparison against base commit 9bfeb6f.

[github-actions]

Matrix SDK

Integration Tests Results:

• [org.matrix.android.sdk.session]
  passed="21" failures="1" errors="0" skipped="2"
• [org.matrix.android.sdk.account]
  passed="5" failures="0" errors="0" skipped="2"
• [org.matrix.android.sdk.internal]
  passed="158" failures="12" errors="0" skipped="38"
• [org.matrix.android.sdk.ordering]
  passed="16" failures="0" errors="0" skipped="0"
• [org.matrix.android.sdk.PermalinkParserTest]
  passed="2" failures="0" errors="0" skipped="0"

[bmarty]

Ok, I have done more check, I think this is fine!