Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting social providers by priority #4379

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Sorting social providers by priority #4379

merged 2 commits into from
Nov 2, 2021

Conversation

ouchadam
Copy link
Contributor

@ouchadam ouchadam commented Nov 1, 2021

Fixes #4277

Orders the SSO providers by the priority in SsoIdentityProvider

BEFORE AFTER
before-sso after-sso
before-sso-sign-up after-sso-sign-up
before-sso-sign-in after-sso-sign-in

@github-actions
Copy link

github-actions bot commented Nov 1, 2021 •
edited
Loading

Unit Test Results

  62 files  ±0    62 suites  ±0   1m 6s ⏱️ +15s
118 tests ±0  118 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
350 runs  ±0  350 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c261340. ± Comparison against base commit 0d6e8bd.

♻️ This comment has been updated with latest results.

bmarty
bmarty approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks

@bmarty bmarty merged commit 26f8f5d into develop Nov 2, 2021
@bmarty bmarty deleted the feature/adm/sso-ordering branch November 2, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort SSO providers by relevance
2 participants
@ouchadam @bmarty