Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing device_one_time_keys_count in sync response causes no keys to be uploaded #3725

Closed
dbkr opened this issue Jul 22, 2021 · 3 comments
Closed

Missing device_one_time_keys_count in sync response causes no keys to be uploaded #3725

dbkr opened this issue Jul 22, 2021 · 3 comments
Assignees
@bmarty
Labels
S-Critical Prevents work, causes data loss and/or has no workaround
Milestone
Sprint - Element ...

Comments

@dbkr
Copy link
Member

dbkr commented Jul 22, 2021

matrix-org/synapse#10214 was recently merged to synapse which caused it to omit the device_one_time_keys_count section if no OTKs of any type were present. Element android only calls updateOneTimeKeyCount if the section is present (https://github.com/vector-im/element-android/blob/2864101e2aa2368ceac89e7532b6944530a8bdb4/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/DefaultCryptoService.kt#L417) so this caused a new session to never upload any OTKs, meaning all messages would be undecryptable.
@anoadragon453 anoadragon453 mentioned this issue Jul 22, 2021
Closed
dbkr added a commit to matrix-org/synapse that referenced this issue Jul 22, 2021
@dbkr
Always send device_one_time_keys_count
ae717dc 
As per comment

Fixes #10456
See also element-hq/element-android#3725
@dbkr dbkr mentioned this issue Jul 22, 2021
Merged
4 tasks
@bmarty bmarty self-assigned this Jul 22, 2021
@bmarty
Copy link
Member

bmarty commented Jul 22, 2021

Currently handled in #3724 (in progress)

@bmarty bmarty added this to the Sprint - Element 1.1.14 milestone Jul 22, 2021
@dbkr dbkr changed the title Missing device_one_time_keys_count is sync response causes no keys to be uploaded Missing device_one_time_keys_count in sync response causes no keys to be uploaded Jul 22, 2021
This was referenced Jul 22, 2021
Closed
Closed
Closed
erikjohnston pushed a commit to matrix-org/synapse that referenced this issue Jul 22, 2021
@dbkr
Always send device_one_time_keys_count (#10457)
7da24b9 
As per comment

Fixes #10456
See also element-hq/element-android#3725
@deepbluev7
Copy link
Contributor

This issue may be one of the reasons, why E2EE doesn't work properly on Conduit.

@bmarty
Copy link
Member

bmarty commented Jul 23, 2021

Fixed in #3724
Element Android 1.1.14

@bmarty bmarty closed this as completed Jul 23, 2021
@bmarty bmarty added S-Critical Prevents work, causes data loss and/or has no workaround and removed 🔥 fire labels Oct 27, 2021
@S7evinK S7evinK mentioned this issue May 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
S-Critical Prevents work, causes data loss and/or has no workaround
Projects
None yet
Milestone
Sprint - Element 1.1.14
Development

No branches or pull requests
3 participants
@dbkr @bmarty @deepbluev7