Inline the avatar mark to remove the react-dom/server dependency #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandhose
requested review from
dbkr and
robintown
and removed request for
a team
Deploying compound-web with
|
| Latest commit: |
66b8fea
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://407c8746.compound-web.pages.dev |
| Branch Preview URL: | https://quenting-inline-avatar-mask.compound-web.pages.dev |
sandhose
force-pushed
the
quenting/inline-avatar-mask
branch
from
fd5fd47
to
643929a
Compare
t3chguy
reviewed
Jun 20, 2024
sandhose
force-pushed
the
quenting/inline-avatar-mask
branch
from
643929a
to
828459a
Compare
I would agree for icons in the design tokens, but it feels like this path was manually crafted? |
|
React-SDK had a similar mask (before switching to Compound Avatars) which came from Figma |
|
Fine, I replaced that with a raw import of the SVG. I guess the bundle size would be slightly bigger as the SVG has comments in it, but it's nothing compared to react-dom/server |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unnecessarily adds a react renderer to the bundle/dependencies just for a simple SVG that doesn't change.
It's also a step towards removing SVGR from this project.