Release Announcement component #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying compound-web with
|
| Latest commit: |
3a3ef67
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://352ead76.compound-web.pages.dev |
| Branch Preview URL: | https://florianduros-announcement-co.compound-web.pages.dev |
florianduros
force-pushed
the
florianduros/announcement-component
branch
from
44f47a8
to
3833930
Compare
4 tasks
florianduros
force-pushed
the
florianduros/announcement-component
branch
from
26d03ff
to
3bffb9b
Compare
robintown
reviewed
Mar 28, 2024
src/components/ReleaseAnnouncement/ReleaseAnnouncement.stories.tsx
Outdated
Show resolved
Hide resolved
src/components/ReleaseAnnouncement/ReleaseAnnouncement.stories.tsx
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| .description { | ||
| color: var(--cpd-color-gray-500); |
There was a problem hiding this comment.
This seems to now use color/text/on-solid/primary in the designs
There was a problem hiding this comment.
That's the case of the header but the description is on Light/color/gray/500
src/components/ReleaseAnnouncement/ReleaseAnnouncement.test.tsx
Outdated
Show resolved
Hide resolved
robintown
reviewed
Mar 28, 2024
src/components/ReleaseAnnouncement/ReleaseAnnouncement.module.css
Outdated
Show resolved
Hide resolved
MidhunSureshR
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figma release announcement https://www.figma.com/file/WGM39wEVQSJxnSFf6eeVry/Fixing-Threads-notifs?type=design&node-id=1124-2469&mode=design
This component is under the release announcement folder in storybook.
Following element-hq/compound#298, we are using
floating-uiinstead of radix to avoid accessibility issues on floating/popover/tooltip behavior.