Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Table, FilterChips components #124

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add Table, FilterChips components #124

wants to merge 3 commits into from

Conversation

Half-Shot
Copy link
Member

We've been using these in ESS for a while, so it feels like the right time to stabilize them inside compound. I think this is mostly sane, but there are a few outstanding areas:

  • The dropdown menu replacement needs a lot of work. We've been using bootstrap internally, but properly implement dropdowns here.
  • ??

image

@justinbot
Copy link

Should the underlying table use https://www.radix-ui.com/themes/docs/components/table components?
Might allow us to avoid some custom CSS as well.

@dav-is
Copy link

dav-is commented Nov 2, 2023

Should the underlying table use [...]

+1 on using Radix for as much as possible

@Half-Shot
Copy link
Member Author

Half-Shot commented Nov 6, 2023 •
edited
Loading

Should the underlying table use [...]

+1 on using Radix for as much as possible

Works for me 👍. Let me finish off my filter dropdown logics and then I'll refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Half-Shot @justinbot @dav-is