add pull request template (tutorial/tests check) #134
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
Collaborator
|
maybe i'm missing something, but does the template mention writing tests? |
Collaborator
Author
yup, added per your feedback. I realized that we have a quite diverse range of people contributing to this project and also maybe first-timers, so mentioning tests here can be useful while keeping the checklsit minimla. (of course writing tests is assumed amongst core contributors and this checklist is used as a mental "list" to go thru) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR address?
For each PR, we want to ensure there is a tutorial notebook, tests written.
What should the reviewer(s) do?
Please review the content of the template. This template is currently used at https://github.com/scikit-package/scikit-package and has worked pretty well.