Skip to content

fix(clang): Correct literal operator in string_view.h #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vikhik wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(clang): Correct literal operator in string_view.h #572

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d789b6
fix(clang): Correct literal operator in string_view.h
vikhik Mar 28, 2025
67adcd2
fix(clang, C++20): Correct literal operator in string_view.h
vikhik May 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions include/EASTL/string_view.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,26 +684,21 @@ namespace eastl
{
inline namespace string_view_literals
{
EA_CONSTEXPR inline string_view operator "" sv(const char* str, size_t len) EA_NOEXCEPT { return {str, len}; }
EA_CONSTEXPR inline u16string_view operator "" sv(const char16_t* str, size_t len) EA_NOEXCEPT { return {str, len}; }
EA_CONSTEXPR inline u32string_view operator "" sv(const char32_t* str, size_t len) EA_NOEXCEPT { return {str, len}; }
EA_CONSTEXPR inline wstring_view operator "" sv(const wchar_t* str, size_t len) EA_NOEXCEPT { return {str, len}; }

// We've seen _sv trigger the following warning on clang:
// identifier '_sv' is reserved because it starts with '_' at global scope [-Wreserved-identifier]
// Temporarily disable the warning until we figure out why it thinks _sv is "at global scope".
EA_DISABLE_CLANG_WARNING(-Wreserved-identifier)
// Backwards compatibility.
EA_CONSTEXPR inline string_view operator "" _sv(const char* str, size_t len) EA_NOEXCEPT { return {str, len}; }
EA_CONSTEXPR inline u16string_view operator "" _sv(const char16_t* str, size_t len) EA_NOEXCEPT { return {str, len}; }
EA_CONSTEXPR inline u32string_view operator "" _sv(const char32_t* str, size_t len) EA_NOEXCEPT { return {str, len}; }
EA_CONSTEXPR inline wstring_view operator "" _sv(const wchar_t* str, size_t len) EA_NOEXCEPT { return {str, len}; }
EA_CONSTEXPR inline string_view operator ""_sv(const char* str, size_t len) EA_NOEXCEPT { return {str, len}; }
EA_CONSTEXPR inline u16string_view operator ""_sv(const char16_t* str, size_t len) EA_NOEXCEPT { return {str, len}; }
EA_CONSTEXPR inline u32string_view operator ""_sv(const char32_t* str, size_t len) EA_NOEXCEPT { return {str, len}; }
EA_CONSTEXPR inline wstring_view operator ""_sv(const wchar_t* str, size_t len) EA_NOEXCEPT { return {str, len}; }
EA_RESTORE_CLANG_WARNING() // -Wreserved-identifier

// C++20 char8_t support.
#if EA_CHAR8_UNIQUE
EA_CONSTEXPR inline u8string_view operator "" sv(const char8_t* str, size_t len) EA_NOEXCEPT { return {str, len}; }
EA_CONSTEXPR inline u8string_view operator "" _sv(const char8_t* str, size_t len) EA_NOEXCEPT { return {str, len}; }
EA_CONSTEXPR inline u8string_view operator ""_sv(const char8_t* str, size_t len) EA_NOEXCEPT { return {str, len}; }
#endif
}
}
Expand Down