Remove char8_t define for EA_PLATFORM_APPLE #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `typedef char char8_t` seems to work plenty fine for me, and I'm getting conflicts with libfmt because both libraries are trying to declare char8_t types. In fmt's case, `enum char8_t : unsigned char {};` is used after checking for the __cpp_char8_t macro. Weirdly having the conflicting types (EA's char typedef and fmt's enum) seems to work...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
typedef char char8_t;seems to work plenty fine for me, and I'm getting conflicts with libfmt because both libraries are trying to declare char8_t types. In fmt's case,enum char8_t : unsigned char {};is used after checking for the__cpp_char8_tmacro. Weirdly having the conflicting types (EA's char typedef and fmt's enum) seems to work...I'm definitely open to other solutions because I foresee this kind of issue arising when multiple projects are trying to use/define char8_t like this.
Edit: For clarification I'm using XCode 10.3