Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update python module API #823

Merged
merged 7 commits into from
Mar 2, 2023
Merged

update python module API #823

merged 7 commits into from
Mar 2, 2023

Conversation

simonpintarelli
Copy link
Collaborator

  • tweaks required for Wave-functions
  • cleanup, simplify smearing
  • bring back OT method in python

@simonpintarelli simonpintarelli marked this pull request as draft March 1, 2023 12:23
mtaillefumier
mtaillefumier approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@mtaillefumier mtaillefumier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have much experience with interfacing C/C++ with python but I do not think anything is wrong with this PR.
If you wish to merge it please do.

@simonpintarelli simonpintarelli marked this pull request as ready for review March 2, 2023 13:58
@simonpintarelli simonpintarelli merged commit 4610012 into develop Mar 2, 2023
@simonpintarelli simonpintarelli deleted the update-python-module branch March 2, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtaillefumier mtaillefumier mtaillefumier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonpintarelli @mtaillefumier