-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: update api for python module, drop python2 #777
Conversation
e915b5c
to
eb03ec5
Compare
@@ -95,7 +95,7 @@ class Sirius(CMakePackage, CudaPackage): | |||
depends_on('pkgconfig', type='build') | |||
|
|||
# Python module | |||
depends_on('python', when='+python', type=('build', 'run')) | |||
depends_on('python', when='+python@3.6:', type=('build', 'run')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should drop this file as well and submit changes directly to the spack package of sirius
The vector3d intrface is not working properly. This works but is awkward: This should be the intrface (https://github.com/electronic-structure/SIRIUS/blob/update/python-module/examples/python/Si_dft.py#L30), but it gives the error:
|
I'll have a look. |
@toxa81 Now both variants |
This looks good to me now. Unless @simonpintarelli you really want to work on |
@toxa81 Let's merge it. I'll work on it later. |
py_sirius.cpp
into multiple cpp files