Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add semver dependency #535

Merged
merged 3 commits into from
Sep 20, 2024
Merged

chore: add semver dependency #535

merged 3 commits into from
Sep 20, 2024

Conversation

rtritto
Copy link
Contributor

@rtritto rtritto commented Sep 20, 2024 •
edited
Loading

semver dependency is added and deduped in lock file.

Replace #534

Fix #516

@rtritto rtritto requested a review from a team as a code owner September 20, 2024 22:21
@rtritto rtritto mentioned this pull request Sep 20, 2024
Closed
erickzhao
erickzhao approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

We usually limit lockfile changes to maintainers so I reverted the lockfile changes and reapplied them myself manually.

@erickzhao erickzhao merged commit 49a4f1e into electron:main Sep 20, 2024
3 checks passed
@rtritto rtritto deleted the add-semver branch September 21, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing semver dependency
2 participants
@rtritto @erickzhao