Skip to content

Please package src alongside the app #532

Open

Description

I just got a really great error message:

An unhandled rejection has occurred inside Forge:
Error: Failed with exit code: 1
Output:
Attempting to build package from 'aquareum_desktop.nuspec'.
'0.1.3-41ee5c4c' is not a valid version string.
Parameter name: version
at ChildProcess.<anonymous> (/home/iameli/code/aquareum/node_modules/electron-winstaller/src/spawn-promise.ts:51:16)
    at ChildProcess.emit (node:events:520:28)
    at ChildProcess.emit (node:domain:488:12)
    at maybeClose (node:internal/child_process:1105:16)
    at Socket.<anonymous> (node:internal/child_process:457:11)
    at Socket.emit (node:events:532:35)
    at Socket.emit (node:domain:488:12)
    at Pipe.<anonymous> (node:net:339:12)

I was like, oh cool! Source maps worked correctly, I can look at the TypeScript to see what was happening when the error happened! Except I can't, because this package doesn't publish its sources. /home/iameli/code/aquareum/node_modules/electron-winstaller/src/spawn-promise.ts does not exist. May I suggest that adding (tar cz src | wc -c ==) 6473 bytes to the distributed package would make lives a bit easier?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions