Skip to content

When using hookModulePath option in windowsSign, Only Setup.exe and Setup.msi are signed, all other internal binaries are not signed. #509

Closed

Description

I'm using the hookModulePath option to sign the installer with custom logic.
Even though the logs show that the installer and all the internal binaries were signed successfully, Only Setup.exe and Setup.msi are signed. All the other internal binaries are not signed when the app is installed.

Configuration used

{
   windowsSign : {
        hookModulePath : 'signHook.js'
    }
}

signHook.js

const exec = require('child_process').exec;

module.exports = async function (filePath) {
    console.log(`going to sign ${filePath}` );
    exec("cmd.exe /c <path to custom signing bat file> " + filePath );
}

Previously I was using signWithParams option and all the internal binaries were signed properly.
Sharing the debug logs when using windowsSign for reference.

debug logs when using windowsSign

electron-windows-installer:main @electron/windows-sign sea
{
  bin: '......\\nvm\\v20.12.0\\node.exe',
  script: '...\\node_modules\\electron-winstaller\\vendor\\receiver.mjs'
}
going to sign ......\AppData\Local\SquirrelTemp\tempf\lib\net45\AppTitle.exe
Successfully signed ......\AppData\Local\SquirrelTemp\tempf\lib\net45\AppTitle.exe undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions