Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add blog post for Electron 33.0.0 release #656

Merged
merged 11 commits into from
Oct 16, 2024
Merged

docs: add blog post for Electron 33.0.0 release #656

merged 11 commits into from
Oct 16, 2024

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Oct 14, 2024

This PR adds a new blog post for Electron 33. @electron/wg-releases, @electron/wg-outreach

Merge target: October 15th, after 33.0.0 releases.

⚠️ Do not merge until the following are completed ⚠️

  • Update node, v8 and chromium versions from final chrome roll under Stack Changes section
  • Edit link for M130 "New In Chrome" blog post
  • Add a few bullets for New Features section
  • Add any missing items in Breaking Changes section
  • Update End of Support

Note: The "Check Blog links" job is going to fail until the Chrome 130 announcement blog comes out. A fail is expected until about Tuesday

@ckerr ckerr requested a review from a team as a code owner October 14, 2024 23:27
Copy link

cloudflare-workers-and-pages bot commented Oct 14, 2024

Deploying electron-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: a096914
Status: ✅  Deploy successful!
Preview URL: https://3099c8a7.electron-website.pages.dev
Branch Preview URL: https://docs-e-33-blog.electron-website.pages.dev

View logs

Copy link
Member

@alicelovescake alicelovescake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through the post and looks good to me! The CI seems to call out the link for new-in-chrome-130 doesn't exist currently but I'm assuming it will be release soon? Currently the beta link is live. https://developer.chrome.com/blog/chrome-130-beta

@ckerr
Copy link
Member Author

ckerr commented Oct 15, 2024

The CI seems to call out the link for new-in-chrome-130 doesn't exist currently but I'm assuming it will be release soon?

Yes, I think this is right. I've copied this into the PR description from @VerteDinde's 32.0.0 blog post PR:

Note: The "Check Blog links" job is going to fail until the Chrome 128 130 announcement blog comes out. A fail is expected until about Tuesday

Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Details of #41205 need to be updated to reflect what actually shipped.

blog/electron-33-0.md Outdated Show resolved Hide resolved
blog/electron-33-0.md Outdated Show resolved Hide resolved
blog/electron-33-0.md Outdated Show resolved Hide resolved
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, one suggested change adding some more details to the C++20 change. Thanks Charles!

Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
@ckerr ckerr merged commit 7666489 into main Oct 16, 2024
5 checks passed
@ckerr ckerr deleted the docs/e-33-blog branch October 16, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants