Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add Breach to Barrier: Strengthening Apps with the Sandbox #449

Merged
merged 9 commits into from
Sep 29, 2023
Merged

docs: Add Breach to Barrier: Strengthening Apps with the Sandbox #449

merged 9 commits into from
Sep 29, 2023

Conversation

felixrieseberg
Copy link
Member

Adds a blog post!

@felixrieseberg felixrieseberg requested review from a team as code owners September 22, 2023 01:00
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-449 September 22, 2023 01:00 Inactive
@felixrieseberg felixrieseberg changed the title Add Breach to Barrier: Strengthening Apps with the Sandbox docs: Add Breach to Barrier: Strengthening Apps with the Sandbox Sep 22, 2023
malept
malept reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving review of the content to others.

blog/breach-to-barrier.md Outdated Show resolved Hide resolved
blog/breach-to-barrier.md Outdated Show resolved Hide resolved
blog/breach-to-barrier.md Outdated Show resolved Hide resolved
blog/breach-to-barrier.md Outdated Show resolved Hide resolved
blog/breach-to-barrier.md Outdated Show resolved Hide resolved
@felixrieseberg @malept
Apply suggestions from code review
97341d9 
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
@felixrieseberg
Copy link
Member Author

Thank you, @malept!

@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-449 September 22, 2023 16:29 Inactive
@malept malept requested a review from a team September 22, 2023 16:33
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-449 September 22, 2023 16:47 Inactive
dsanders11
dsanders11 reviewed Sep 23, 2023
View reviewed changes
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped some comments.

blog/breach-to-barrier.md Outdated Show resolved Hide resolved
blog/breach-to-barrier.md Outdated Show resolved Hide resolved
blog/breach-to-barrier.md Outdated Show resolved Hide resolved
@felixrieseberg @dsanders11
Update blog/breach-to-barrier.md
8f46337 
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-449 September 25, 2023 17:51 Inactive
@felixrieseberg
Copy link
Member Author

Thank you, all feedback implemented!

@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-449 September 25, 2023 18:07 Inactive
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-449 September 27, 2023 17:01 Inactive
MarshallOfSound
MarshallOfSound reviewed Sep 28, 2023
View reviewed changes
blog/breach-to-barrier.md Outdated Show resolved Hide resolved
blog/breach-to-barrier.md Outdated Show resolved Hide resolved
felixrieseberg and others added 2 commits September 28, 2023 09:41
@felixrieseberg @MarshallOfSound
Update blog/breach-to-barrier.md
cf1272f 
Co-authored-by: Samuel Attard <sam@electronjs.org>
@felixrieseberg @MarshallOfSound
Update blog/breach-to-barrier.md
970b121 
Co-authored-by: Samuel Attard <sam@electronjs.org>
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-449 September 28, 2023 16:42 Inactive
VerteDinde
VerteDinde approved these changes Sep 29, 2023
View reviewed changes
blog/breach-to-barrier.md Show resolved Hide resolved
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-449 September 29, 2023 20:15 Inactive
@felixrieseberg felixrieseberg merged commit 245d42a into main Sep 29, 2023
3 checks passed
@felixrieseberg felixrieseberg deleted the felixr-sandbox-post branch September 29, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao left review comments

@MarshallOfSound MarshallOfSound MarshallOfSound left review comments

@malept malept malept left review comments

@dsanders11 dsanders11 dsanders11 approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@felixrieseberg @malept @VerteDinde @dsanders11 @MarshallOfSound @erickzhao