Conversation
add node-pre-gyp as dependency check if module is node-pre-gyp ready otherwise fallback to node-gyp check if module is node-pre-gyp ready use the module path from package json correctly
|
Can you explain exactly what this achieves, as far as I am aware |
|
node-pre-gyp can build the packages for electronif the runtime and disturl and so on is specified correctly. It can also download the prebuild packages from the specified host.
|
|
As far as I am aware If this PR actually fixes a bug please raise that as an issue and we can look at solving it without bring in the |
|
@MarshallOfSound so please consider add |
This PR modifies electron-rebuild to use node-pre-gyp if the binary section is present. It uses the --fallback-to-build option to build the dependency if no prebuild binary is available.