Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Test current versions of Node.js #1085

Closed
wants to merge 2 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jun 13, 2023

Builds on #1084 to have CircleCI test on the versions of Node.js at https://github.com/nodejs/release#readme

Linux 20 fails on:

[4/4] Building fresh packages...
$ npm run compile
/usr/bin/env: ‘node’: Text file busy
error Command failed with exit code 126.

@cclauss cclauss requested a review from a team as a code owner June 13, 2023 12:23
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023

Codecov Report

Merging #1085 (1cb2db2) into main (29365ad) will decrease coverage by 0.43%.
The diff coverage is 78.43%.

@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
- Coverage   76.44%   76.01%   -0.43%     
==========================================
  Files          19       20       +1     
  Lines         692      688       -4     
  Branches      134      129       -5     
==========================================
- Hits          529      523       -6     
  Misses        118      118              
- Partials       45       47       +2     
Impacted Files Coverage Δ
src/clang-fetcher.ts 81.42% <ø> (+0.34%) ⬆️
src/module-type/prebuild-install.ts 89.28% <ø> (-0.72%) ⬇️
src/module-type/node-gyp/node-gyp.ts 83.87% <75.00%> (ø)
src/module-type/node-gyp/worker.ts 76.19% <76.19%> (ø)
src/module-rebuilder.ts 91.52% <100.00%> (ø)
src/sysroot-fetcher.ts 83.87% <100.00%> (-0.51%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dsanders11
Copy link
Member

The Linux 20 failure in this PR looks to be related to Node.js 20.3.0, see websockets/bufferutil#152. Testing with 20.2.0 works.

@cclauss
Copy link
Contributor Author

cclauss commented Jun 14, 2023

Downgrade to Linux Node.js v20.2 passes the tests.

@cclauss
Copy link
Contributor Author

cclauss commented Jun 14, 2023

Closing in favor of #1086

@cclauss cclauss closed this Jun 14, 2023
@cclauss cclauss deleted the ci-test-current-Node.js branch June 14, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants