fix: sanitize basename for name starting with a number #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davej in the meantime it is possible to solve the issue by applying a pnpm patch |
BlackHole1
approved these changes
Jun 17, 2025
|
Can you fix the issue of the test failure? |
|
Hi @BlackHole1 ! I fixed the linter issue! |
|
Hi @BlackHole1 ! Do you have any news for the PR? |
mmaietta
reviewed
Jul 8, 2025
| }); | ||
| const result = await spawn( | ||
| 'codesign', | ||
| ['-dv', '-vvvv', '--deep', `./${path.basename(opts.appPath)}`], |
There was a problem hiding this comment.
Just curious, why basename relative to root? Why not path.resolve(opts.appPath)?
There was a problem hiding this comment.
I honestly have no idea, it was a previous change I kept. My contribution is on escaping the command argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue encountered when using an App name starting with a number with
electron/notarize.The call to codesign is now sanitized to be interpreted as a filename and not a process.
This issue was references in #237