Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

fix: use crowdin-glossary #336

Merged
merged 6 commits into from
May 8, 2018
Merged

fix: use crowdin-glossary #336

merged 6 commits into from
May 8, 2018

Conversation

zeke
Copy link
Contributor

@zeke zeke commented May 3, 2018

This PR:

  • documents the two types of glossaries we're working with (see below)
  • uses the new crowdin-glossary module to generate and upload a Crowdin Glossary
  • changes the names of a bunch of internal stuff to help differentiate between the two glossary types.

There are two different "glossaries" in the Electron world:

1. The Electron Glossary

The Electron Glossary is a hand-written markdown file. It defines terms
that are common in Electron development, like "ASAR", "IPC", "V8", etc.
To add entries to it, open a pull request on the electron/electron repository.

2. The Crowdin Glossary

The Crowdin Glossary is programatically generated. It defines terms to give
translators context when translating in the Crowdin UI, and to help avoid
translations of strings like Array and win.open() that should remain in
their original "English" form. It includes entries for JavaScript builtins,
Electron API names, method names, event names, etc. To modify this glossary,
see script/upload-crowdin-glossary.js

This PR is marked WIP because something is currently broken with the Crowdin upload. I pinged their team about it, and we are waiting on Crowdin support to investigate the issue.

cc @Andrulko

Resolves #329

@zeke zeke changed the title [WIP] use crowdin-glossary fix: use crowdin-glossary May 8, 2018
@zeke zeke force-pushed the improve-glossary branch from efcc1f8 to 0fb1903 Compare May 8, 2018 18:13
@electron electron deleted a comment from ci-reporter bot May 8, 2018
@zeke zeke merged commit 27dd64c into master May 8, 2018
@zeke zeke deleted the improve-glossary branch May 8, 2018 22:25
@electron-bot
Copy link
Contributor

🎉 This PR is included in version 1.77.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants