Skip to content

Conversation

@BlackHole1
Copy link
Member

@BlackHole1 BlackHole1 commented Aug 11, 2022

As of v2.0.0, the minimum nodejs version we support is 12. so global-tunnel-ng no longer has any effect.

cc: @malept

@malept
Copy link
Member

malept commented Aug 11, 2022

This should be a fix since it's removing an unnecessary dependency

@BlackHole1 BlackHole1 changed the title refactor: remove global-tunnel-ng library fix: remove global-tunnel-ng library Aug 11, 2022
@BlackHole1 BlackHole1 force-pushed the remove-global-tunnel-ng branch from ae6cbdd to 2852a1e Compare August 11, 2022 03:19
@BlackHole1
Copy link
Member Author

This should be a fix since it's removing an unnecessary dependency

Done

@erickzhao erickzhao requested a review from a team August 11, 2022 17:05
@BlackHole1
Copy link
Member Author

Looks like we can merge?

@erickzhao erickzhao merged commit 4fe5b00 into electron:main Oct 18, 2022
@electron-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@BlackHole1 BlackHole1 deleted the remove-global-tunnel-ng branch October 19, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants