Skip to content

fix: parse proxy error #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
malept merged 4 commits into from
Mar 14, 2022
Merged

fix: parse proxy error #216

malept merged 4 commits into from
Mar 14, 2022

Conversation

@BlackHole1
Copy link
Member

@BlackHole1 BlackHole1 commented Mar 14, 2022 •
edited
Loading

Close: #215

Sorry. This is a very stupid bug... 🤦‍♂️🤦‍♂️🤦‍♂️

Because:

process.env.A = undefined

process.env.A === 'undefined' // => true

typeof process.env.A // => 'string'

cc: @malept

@malept malept requested a review from a team March 14, 2022 16:06
@BlackHole1 BlackHole1 mentioned this pull request Mar 14, 2022
Merged
malept
malept reviewed Mar 14, 2022
View reviewed changes
malept
malept reviewed Mar 14, 2022
View reviewed changes
@malept malept merged commit c99de4b into electron:main Mar 14, 2022
@electron-bot
Copy link
Contributor

electron-bot commented Mar 14, 2022

🎉 This PR is included in version 1.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@BlackHole1 BlackHole1 deleted the fix-process-env-failed branch March 15, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malept malept malept left review comments

@erickzhao erickzhao erickzhao approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GLOBAL_AGENT.HTTP_PROXY configuration value: URL protocol must be http:

4 participants

@BlackHole1 @electron-bot @malept @erickzhao