makerbase tests

packages/maker/base/package.json

@@ -10,7 +10,8 @@
   "devDependencies": {
     "chai": "^4.3.3",
     "mocha": "^9.0.1",
-    "sinon": "^13.0.1"
+    "sinon": "^13.0.1",
+    "vitest": "^2.1.6"
   },
   "engines": {
     "node": ">= 16.4.0"

packages/maker/base/test/config-fetcher_spec.ts → packages/maker/base/spec/config-fetcher.spec.ts

@@ -1,45 +1,39 @@
-import { expect } from 'chai';
-import { stub } from 'sinon';
+import { describe, expect, it, vi } from 'vitest';
 
 import { MakerBase } from '../src/Maker';
 
 class MakerImpl extends MakerBase<{ a: number }> {
   name = 'test';
-
   defaultPlatforms = [];
 }
 
 describe('prepareConfig', () => {
   it('should accept sync configure functions', async () => {
-    const fetcher = stub();
-    fetcher.returns({
+    const fetcher = vi.fn();
+    fetcher.mockReturnValue({
       a: 123,
     });
     const maker = new MakerImpl(fetcher, []);
-    expect(maker.config).to.be.undefined;
-    expect(fetcher.callCount).to.equal(0);
     await maker.prepareConfig('x64');
-    expect(maker.config).to.deep.equal({
+    expect(maker.config).toEqual({
       a: 123,
     });
-    expect(fetcher.callCount).to.equal(1);
-    expect(fetcher.firstCall.args).to.deep.equal(['x64']);
+    expect(fetcher).toHaveBeenCalledOnce();
+    expect(fetcher).toHaveBeenCalledWith('x64');
   });
 
   it('should accept async configure functions', async () => {
-    const fetcher = stub();
-    fetcher.resolves({
+    const fetcher = vi.fn();
+    fetcher.mockResolvedValue({
       a: 123,
     });
     const maker = new MakerImpl(fetcher, []);
-    expect(maker.config).to.be.undefined;
-    expect(fetcher.callCount).to.equal(0);
     await maker.prepareConfig('x64');
-    expect(maker.config).to.deep.equal({
+    expect(maker.config).toEqual({
       a: 123,
     });
-    expect(fetcher.callCount).to.equal(1);
-    expect(fetcher.firstCall.args).to.deep.equal(['x64']);
+    expect(fetcher).toHaveBeenCalledOnce();
+    expect(fetcher).toHaveBeenCalledWith('x64');
   });
 
   it('should hand through the provided object', async () => {
@@ -49,9 +43,9 @@ describe('prepareConfig', () => {
       },
       []
     );
-    expect(maker.config).to.be.undefined;
+    expect(maker.config).toBeUndefined();
     await maker.prepareConfig('x64');
-    expect(maker.config).to.deep.equal({
+    expect(maker.config).toEqual({
       a: 234,
     });
   });

packages/maker/base/spec/ensure-output.spec.ts

@@ -0,0 +1,66 @@
+import fs from 'node:fs';
+import os from 'node:os';
+import path from 'node:path';
+
+import { afterEach, beforeEach, describe, expect, it } from 'vitest';
+
+import { EmptyConfig, MakerBase } from '../src/Maker';
+
+class MakerImpl extends MakerBase<EmptyConfig> {
+  name = 'test';
+
+  defaultPlatforms = [];
+}
+
+const maker = new MakerImpl({}, []);
+let tmpDir: string;
+
+describe('ensure-output', () => {
+  beforeEach(async () => {
+    const tmp = os.tmpdir();
+    const tmpdir = path.join(tmp, 'electron-forge-test-');
+    tmpDir = await fs.promises.mkdtemp(tmpdir);
+  });
+
+  afterEach(async () => {
+    await fs.promises.rm(tmpDir, { recursive: true });
+  });
+
+  describe('ensureDirectory', () => {
+    it('should delete the directory contents if it exists', async () => {
+      fs.mkdirSync(path.resolve(tmpDir, 'foo'));
+      fs.writeFileSync(path.resolve(tmpDir, 'foo', 'touchedFile'), '');
+      expect(fs.existsSync(path.resolve(tmpDir, 'foo', 'touchedFile'))).toEqual(true);
+
+      await maker.ensureDirectory(path.resolve(tmpDir, 'foo'));
+
+      expect(fs.existsSync(path.resolve(tmpDir, 'foo', 'touchedFile'))).toEqual(false);
+    });
+
+    it('should create the directory if it does not exist', async () => {
+      expect(fs.existsSync(path.resolve(tmpDir, 'bar'))).toEqual(false);
+      await maker.ensureDirectory(path.resolve(tmpDir, 'bar'));
+      expect(fs.existsSync(path.resolve(tmpDir, 'bar'))).toEqual(true);
+    });
+  });
+
+  describe('ensureFile', () => {
+    it('should delete the file if it exists', async () => {
+      fs.mkdirSync(path.resolve(tmpDir, 'foo'));
+      fs.writeFileSync(path.resolve(tmpDir, 'foo', 'touchedFile'), '');
+      expect(fs.existsSync(path.resolve(tmpDir, 'foo', 'touchedFile'))).toEqual(true);
+
+      await maker.ensureFile(path.resolve(tmpDir, 'foo'));
+
+      expect(fs.existsSync(path.resolve(tmpDir, 'foo', 'touchedFile'))).toEqual(false);
+    });
+
+    it('should create the containing directory if it does not exist', async () => {
+      expect(fs.existsSync(path.resolve(tmpDir, 'bar'))).toEqual(false);
+
+      await maker.ensureFile(path.resolve(tmpDir, 'bar', 'file'));
+
+      expect(fs.existsSync(path.resolve(tmpDir, 'bar'))).toEqual(true);
+    });
+  });
+});

packages/maker/base/test/support_spec.ts → packages/maker/base/spec/support.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'chai';
+import { describe, expect, it } from 'vitest';
 
 import { EmptyConfig, MakerBase } from '../src/Maker';
 
@@ -14,6 +14,6 @@ describe('ensureExternalBinariesExist', () => {
   const maker = new MakerImpl({}, []);
 
   it('throws an error when one of the binaries does not exist', () => {
-    expect(() => maker.ensureExternalBinariesExist()).to.throw(/the following external binaries need to be installed: bash, nonexistent/);
+    expect(() => maker.ensureExternalBinariesExist()).toThrow(/the following external binaries need to be installed: bash, nonexistent/);
   });
 });

packages/maker/base/test/version_spec.ts → packages/maker/base/spec/version.spec.ts

@@ -1,4 +1,4 @@
-import { expect } from 'chai';
+import { describe, expect, it } from 'vitest';
 
 import { EmptyConfig, MakerBase } from '../src/Maker';
 
@@ -13,15 +13,15 @@ describe('normalizeWindowsVersion', () => {
 
   it('removes everything after the dash', () => {
     for (const version of ['1.0.0-alpha', '1.0.0-alpha.1', '1.0.0-0.3.7', '1.0.0-x.7.z.92']) {
-      expect(maker.normalizeWindowsVersion(version)).to.equal('1.0.0.0');
+      expect(maker.normalizeWindowsVersion(version)).toEqual('1.0.0.0');
     }
   });
   it('removes everything after the plus sign', () => {
     for (const version of ['1.0.0-alpha+001', '1.0.0+20130313144700', '1.0.0-beta+exp.sha.5114f85', '1.0.0+21AF26D3----117B344092BD']) {
-      expect(maker.normalizeWindowsVersion(version)).to.equal('1.0.0.0');
+      expect(maker.normalizeWindowsVersion(version)).toEqual('1.0.0.0');
     }
   });
   it('does not truncate the version when there is no dash', () => {
-    expect(maker.normalizeWindowsVersion('2.0.0')).to.equal('2.0.0.0');
+    expect(maker.normalizeWindowsVersion('2.0.0')).toEqual('2.0.0.0');
   });
 });