Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add preStart hook and port existing startLogic impls #3720

Merged
merged 2 commits into from
Nov 12, 2024
Merged

feat: add preStart hook and port existing startLogic impls #3720

merged 2 commits into from
Nov 12, 2024

Conversation

MarshallOfSound
Copy link
Member

We already had postStart so this is pretty chill 🤷 Removes the "only one thing can mess with start logic" restriction for our own plugins.

@MarshallOfSound MarshallOfSound requested a review from a team as a code owner September 25, 2024 20:55
erickzhao
erickzhao previously requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we formally deprecate startLogic instead of removing it in this PR in case third-party plugin authors are using it right?

erickzhao
erickzhao approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't forget to add docs before releasing but LGTM

@georgexu99 georgexu99 added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit a2d704e Nov 12, 2024
12 checks passed
@georgexu99 georgexu99 deleted the pre-start branch November 12, 2024 18:40
@georgexu99 georgexu99 mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarshallOfSound @VerteDinde @erickzhao @georgexu99