Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(plugins/electronegativity): correct some config types #3482

Merged
merged 2 commits into from
Feb 2, 2024
Merged

chore(plugins/electronegativity): correct some config types #3482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0f2e7d
chore(plugins/electronegativity): fix types
Dogdriip Feb 1, 2024
a7860df
Merge branch 'main' into patch-1
BlackHole1 Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/plugin/electronegativity/src/ElectronegativityPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export type ElectronegativityConfig = {
*
* Defaults to `false`.
*/
isRelative?: false;
isRelative?: boolean;
/**
* Specify a range to run Electron upgrade checks. For example, `'7..8'` checks an upgrade
* from Electron 7 to Electron 8.
Expand All @@ -49,7 +49,7 @@ export type ElectronegativityConfig = {
*
* Defaults to empty array (`[]`)
*/
parserPlugins: Array<string>;
parserPlugins?: Array<string>;
};

export default class ElectronegativityPlugin extends PluginBase<ElectronegativityConfig> {
Expand All @@ -65,6 +65,7 @@ export default class ElectronegativityPlugin extends PluginBase<Electronegativit
await runElectronegativity(
{
...this.config,
isRelative: this.config.isRelative ?? false,
parserPlugins: this.config.parserPlugins ?? [],
input: options.outputPaths[0],
},
Expand Down
Loading