Open
Description
Pre-flight checklist
- I have read the contribution documentation for this project.
- I agree to follow the code of conduct that this project uses.
- I have searched the issue tracker for a bug that matches the one I want to file, without success.
Electron Forge version
7.3.0
Electron version
v29.1.2
Operating system
Windows 11 23h2
Last known working Electron Forge version
n/a
Expected behavior
Build would be successful using hyphenated version numbers created by npm version prerelease
Actual behavior
An unhandled rejection has occurred inside Forge:
Error: Failed with exit code: 1
Output:
Attempting to build package from 'my_app.nuspec'.
'1.0.1-0' is not a valid version string.
Parameter name: version
at ChildProcess.<anonymous> (D:\dev\versionNumber\my-app\node_modules\electron-winstaller\lib\spawn-promise.js:48:24)
at ChildProcess.emit (node:events:514:28)
at ChildProcess.emit (node:domain:488:12)
at maybeClose (node:internal/child_process:1105:16)
at ChildProcess._handle.onexit (node:internal/child_process:305:5)
Steps to reproduce
- Open a folder
npm init electron-app@latest my-appcd my-appnpm version prerelease- ✅ Observe the version is now 1.0.0-0
npm run make- ❌ Observe you get an unhandled exception
- This only seems to affect
@electron-forge/maker-squirrel. I can build just fine on macOS using@electron-forge/maker-zip
An unhandled rejection has occurred inside Forge:
Error: Failed with exit code: 1
Output:
Attempting to build package from 'my_app.nuspec'.
'1.0.1-0' is not a valid version string.
Parameter name: version
at ChildProcess.<anonymous> (D:\dev\versionNumber\my-app\node_modules\electron-winstaller\lib\spawn-promise.js:48:24)
at ChildProcess.emit (node:events:514:28)
at ChildProcess.emit (node:domain:488:12)
at maybeClose (node:internal/child_process:1105:16)
at ChildProcess._handle.onexit (node:internal/child_process:305:5)
Additional information
No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment