fix: don't concatenate args in addModules#1853
Merged
codebytere merged 1 commit intomainfrom Feb 17, 2026
Merged
Conversation
Member
MarshallOfSound
left a comment
MarshallOfSound
left a comment
There was a problem hiding this comment.
Seems fine but tests are sad
codebytere
force-pushed
the
fix-string-concat
branch
from
5649d7a to
37c98db
Compare
MarshallOfSound
approved these changes
Feb 17, 2026
codebytere
force-pushed
the
fix-string-concat
branch
from
37c98db to
76b08c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in title. We should do this more securely.