chore: update electron-quick-start references #1714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangannyx
commented
Jul 2, 2025
There was a problem hiding this comment.
These mocks are unused to my knowledge
erickzhao
reviewed
Jul 2, 2025
| @@ -13,7 +13,7 @@ import { IpcEvents } from '../ipc-events'; | |||
| // parent directory of all the downloaded template fiddles | |||
| const TEMPLATES_DIR = path.join(app.getPath('userData'), 'Templates'); | |||
|
|
|||
| // location of the fallback template fiddle used iff downloading failed | |||
| // location of the fallback template fiddle used if downloading failed | |||
There was a problem hiding this comment.
I think this was intentional (iff = if and only if)
|
@yangannyx, I think this PR might be missing a commit? I don't see any actual changes to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates references to
electron-quick-startto the renamed repominimal-repro.Fiddle currently uses
electron-quick-startin the folder names of its template caching logic. I decided not to change this logic since it's internal to how fiddle operates and not something general electron consumers will be exposed to