feat: enable v8 sandboxed pointers #34724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
force-pushed
the
sandboxed-pointers
branch
from
bd39f12 to
70b739a
Compare
VerteDinde
approved these changes
Jun 29, 2022
ckerr
approved these changes
Jun 29, 2022
benchmarks showed the function call was slower
deepak1556
approved these changes
Jun 30, 2022
jkleinsc
approved these changes
Jul 5, 2022
|
Release Notes Persisted
|
|
Is there a way to query for this being enabled at runtime? I don't want to cost nodejs users performance just because electron needs an extra memcpy |
3 tasks
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
* feat: enable v8 sandboxed pointers * update breaking-changes.md * update zero-fill patch benchmarks showed the function call was slower
3 tasks
3 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* feat: enable v8 sandboxed pointers * update breaking-changes.md * update zero-fill patch benchmarks showed the function call was slower
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Description of Change
This reworks several allocators in Node to be compatible with V8 sandboxed
pointers.
Notes: Enabled the V8 memory cage for external buffers. See https://www.electronjs.org/blog/v8-memory-cage for more details.